TIKA-2830 add heif mimetype support#278
Merged
tballison merged 2 commits intoapache:masterfrom Jun 16, 2020
Merged
Conversation
makepanic
changed the title
fixes TIKA-2830
Contributor
|
@makepanic I'm sorry this took forever. We had to do some unpleasant shimming to upgrade drewnoakes' metadata extractor. We've done this now, and this should just work now. THANK YOU! |
tballison
pushed a commit
that referenced
this pull request
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes TIKA-2830
I had to bump
com.drewnoakes.metadata-extractorto2.12.0because they added heif support.I'm unsure if the mimetypes are correct like that because the sequence types have no glob.
If I add the same glob to each sequence, the xml parser throws an error.
The spec says that the same extension can be used for different mime types:
Most of the parser code is copied from the webp parser implementation.